Log in with username/password: lyceum/lyceum

Ticket #873 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

charset missing in wp-login.php

Reported by: lyceum Assigned to:
Priority: normal Milestone: 1.0.1
Keywords: charset Cc: xfliu.math@gmail.com

Description (Last modified by jjb)

Such a line is needed if the blog uses "utf-8" encoding, especially for those blogs in non-English language.

header( 'Content-Type: text/html; charset='.get_settings('blog_charset') );

Without such a line, some browser, such as IE, will only show a blank page when there is non-English character in this page.

Here is a patch file from diff:

  • wp-login.php

    old new  
    99$error = ''; 
    1010 
    1111nocache_headers(); 
     12header( 'Content-Type: text/html; charset='.get_settings('blog_charset') ); 
    1213 
    1314if ( defined('RELOCATE') ) { // Move flag is set 
    1415       if ( isset( $_SERVER['PATH_INFO'] ) && ($_SERVER['PATH_INFO'] != $_SERVER['PHP_SELF']) ) 
     
    103104<body> 
    104105 
    105106<div id="login"> 
    106 <h1><a href="http://lyceum.ibiblio.org/">Lyceum</a></h1> 
     107<h1><a href="http://www.xys-reader.org/blogs">Lyceum</a></h1> 
    107108<?php 
    108109if ( $error ) 
    109110       echo "<div id='login_error'>$error</div>"; 

Change History

10/28/07 09:12:01 changed by lyceum

Sorry, in the patch file above, such lines are no meaning.

-<h1><a href="http://lyceum.ibiblio.org/">Lyceum</a></h1>
+<h1><a href="http://www.xys-reader.org/blogs">Lyceum</a></h1>

10/29/07 23:11:18 changed by jjb

  • description changed.

10/29/07 23:23:29 changed by jjb

  • status changed from new to closed.
  • resolution set to fixed.

xfliu-

It actually needs to be 'system_charset', and that was the bug, I was getting the wrong setting. Should be fixed here:

[1254]

Log in with username/password: lyceum/lyceum