Log in with username/password: lyceum/lyceum

Ticket #548 (closed defect: fixed)

Opened 2 years ago

Last modified 8 months ago

"comments in moderation" link doesn't work if there is no trailing slash after 'admin' in url

Reported by: jjb Assigned to: jjb
Priority: normal Milestone: 1.0
Keywords: Cc:

Attachments

classes.php.diff (1.3 kB) - added by jjb on 07/03/06 20:21:35.
I'm pretty sure that with these changes, the directory URL cases work perfectly (only the subdomain case doesn't work).
classes.php.2.diff (1.6 kB) - added by jjb on 09/07/07 00:55:55.
For current 1.0 branch. Still doesn't work with subdomains.

Change History

06/22/06 20:29:52 changed by jjb

in the dashboard, that is.....

06/30/06 13:13:02 changed by jturner@msdpt.k12.in.us

OK - I don't know how to use a system like this, but here is a fix... I hope this is the right place to post:

in the .htaccess file, just before the other admin stuff, add this:

RewriteRule? ([/]+)/admin$ /$1/admin/ [R=301,NC,L]

that way anytime someone goes to: http://whatever/username/admin they'll be redirected to: http://whatever/username/admin/

BTW, if you could email me and let me know the proper way to submit things like this, I'd appreciate it. Thanks.

06/30/06 13:15:20 changed by jturner@msdpt.k12.in.us

OK - that didn't display correctly - let me try again:

        RewriteRule ^([^/]+)/admin$ /$1/admin/ [R=301,NC,L]

07/03/06 12:25:38 changed by jjb

  • summary changed from "comments in moderaion" link doesn't work if there is no trailing slash after 'admin' in url to "comments in moderation" link doesn't work if there is no trailing slash after 'admin' in url.

07/03/06 12:27:59 changed by jjb

jturner--- thank you! that is exactly how i was trying to address this problem and i was having trouble with the rewrite rule.

now you are in trouble though, because i'm going to go to you with all our mod_rewrite problems!! :)

oh and this is exactly how you should submit things like this. if you ever have something with more code and/or a modification to an existing lyceum file, then you can attach a file (such as a .diff) to this ticket.

07/03/06 20:16:30 changed by jjb

  • priority changed from normal to high.
  • milestone changed from 0.32 to 0.40.

Okay I got this working for the direcetory URL cases but am having some trouble finding a solution for subdomains. Am waiting on jturner to get back to some emails. Also since this involves more than tweak-grade changes to the rewrite rules I'm not totally comfortable doing it now that .32 is in release candidate, so moving this to .40 as high priority.

07/03/06 20:21:35 changed by jjb

  • attachment classes.php.diff added.

I'm pretty sure that with these changes, the directory URL cases work perfectly (only the subdomain case doesn't work).

07/03/06 20:22:49 changed by jjb

  • description changed.

07/03/06 20:23:12 changed by jjb

  • description changed.

These are the cases I'm referring to:

  1. directory URLs, lyceum installed as the web root (http://example.com/blogname)
  2. directory URLs, lyceum installed in some subdirectory (http://example.com/path/to/lyceum/blogname)
  3. subdomains (http://blogname.example.com)

09/05/07 02:36:55 changed by jjb

  • priority changed from high to normal.
  • milestone changed from 1.0.1 to 1.0.

09/07/07 00:55:55 changed by jjb

  • attachment classes.php.2.diff added.

For current 1.0 branch. Still doesn't work with subdomains.

09/14/07 20:46:35 changed by jjb

  • status changed from new to closed.
  • resolution set to fixed.
Log in with username/password: lyceum/lyceum